TSCBasic: deprecate <<< operator
#413
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since TSCBasic has become a kitchen sink for multiple types and functions, it's important to be able to selectively import those. It is done by `import struct` and similar statements. Unfortunately, this doesn't work for operators, which means you have to import the whole module when you need access just to a single operator. This inadvertently pollutes the environment of available symbols, which is undesirable. By deprecating the operator and adding a `send(_:)` function on `WritableByteStream` we allow selectively importing this functionality.
MaxDesiatov
force-pushed
the
maxd/deprecate-output-operator
branch
from
35a261b to
6aa85be
Compare
|
@swift-ci test |
|
@swift-ci clean test |
|
SourceKit-LSP/SwiftSyntax CI breakage looks unrelated |
|
@swift-ci test macos |
tomerd
reviewed
Apr 21, 2023
|
@swift-ci test windows |
|
@swift-ci test macos |
I hope it is, but it's used in a bunch of places in SwiftPM like logging that relies on Not something we have to have answers for this particular PR, these are more long-term questions. |
neonichu
approved these changes
Apr 21, 2023
|
@swift-ci test macos |
1 similar comment
|
@swift-ci test macos |
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 26, 2023
Addresses some of the deprecations introduced in swiftlang/swift-tools-support-core#413
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 26, 2023
Addresses some of the deprecations introduced in swiftlang/swift-tools-support-core#413
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 27, 2023
Addresses some of the deprecations introduced in swiftlang/swift-tools-support-core#413
MaxDesiatov
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Apr 27, 2023
Addresses some of the deprecations introduced in swiftlang/swift-tools-support-core#413 Also using this as an opportunity to use string interpolation and raw string literals to make this more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since TSCBasic has become a kitchen sink for multiple types and functions, it's important to be able to selectively import those. It is done with
import struct,import func, and similar statements. Unfortunately, this doesn't work for operators, which means you have to import the whole module when you need access just to a single operator. This inadvertently pollutes the environment of available symbols, which is undesirable.By deprecating the operator and adding a
send(_:)function onWritableByteStreamwe allow selectively importing this functionality without importing the whole module.This also brings the API closer to Swift conventions, which in my understanding don't favor use of operators for stream I/O. Looks like
<<<was initially brought over to TSC as a C++ idiom.