TSCBasic: fix compatibility with Swift 5.5 #415
Conversation
MaxDesiatov
requested review from
abertelrud,
neonichu and
tomerd
as code owners
|
@swift-ci test |
|
@swift-ci test Apple Silicon |
|
@swift-ci clean test macos |
|
I think we should rather update our tools-version to 5.7 to fail early with a clear error message considering that we get all kinds of random module errors in SwiftPM's test suite (which run as part of TSC CI) when using older compilers, the CI nodes really just need to be upgraded to something that works. |
|
@swift-ci test macos |
|
@swift-ci test |
|
@swift-ci test windows |
| @@ -60,7 +60,7 @@ | |||
| "repositoryURL": "https://github.com/apple/swift-syntax.git", | |||
| "state": { | |||
| "branch": "main", | |||
| "revision": "2d5575b8771c5ccd5673428d959085ddb74dbbf7", | |||
| "revision": "a6486790b46a4469bfb2b09d7ff6463aaecc40e5", | |||
There was a problem hiding this comment.
@neonichu this is what made the macOS build fail, maybe we should try to remove this Package.resolved to avoid similar issues in the future?
There was a problem hiding this comment.
IIRC, without it we can't build at all, right? We can try to use an empty one.
|
@swift-ci test |
|
@swift-ci test windows |
1 similar comment
|
@swift-ci test windows |
Some of our CI nodes still support only Swift 5.5 and we should use
UnsafeSendablewith that version instead of@unchecked Sendable.