build: auto-vendor SwiftSystem when not provided #443
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swift now requires CMake 3.19.6 as a minimum version. Assume that we can use CMake newer than 3.16 and simplify the build rules.
When SwiftSystem is not provided to be built against explicitly (i.e. `-D SwiftSystem_DIR=...`), vendor a copy of SwiftSystem to allow the library to be built by including and building its dependencies. This behaviour is similar to how SPM based builds function.
|
@swift-ci please test |
|
@tomerd can we just cut the swift-system dependency actually? IIRC, it was eagerly added in anticipation of using its path type but we have no plans to actually use that anymore. |
|
@neonichu hmm, we can for the vendoring path, but the non-vendored path needs it as imports are public still, and TSC has a dependency on System. |
|
Right, what I mean is that the dependency doesn't actually have any purpose. I opened a PR to remove it: #448 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SwiftSystem is not provided to be built against explicitly (i.e.
-D SwiftSystem_DIR=...), vendor a copy of SwiftSystem to allow thelibrary to be built by including and building its dependencies. This
behaviour is similar to how SPM based builds function.