Put cursor at the end of last line for lit progress animation #464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cursor was placed at the middle of the first progress line
kateinoigakukun
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci Please test |
MaxDesiatov
approved these changes
Feb 5, 2024
|
We need a complete terminal emulator to ensure the rendered cursor position, so there is no simple way, unfortunately. |
|
That's fair, ready for merging then. |
kateinoigakukun
deleted the
pr-aa7b742c4f385f2c9dada756765b93957f479a15
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor was placed at the middle of the first progress line, and it makes the progress bar line too flickering (it's just my feeling). Also the last
Testingline was not printed whenCtrl+Csignal is sent.Screen.Recording.2024-02-03.at.19.30.49.mov