Initial integration of libdispatch into build-script #1030
Conversation
|
Taking the approach as discussed with @parkera on the swift-corelibs-dev list yesdterday of just invoking libdisaptch's autotools build machinery from these scripts. |
| @@ -1284,6 +1300,9 @@ function cmake_config_opt() { | |||
| foundation) | |||
| echo "--config ${FOUNDATION_BUILD_TYPE}" | |||
| ;; | |||
| libdispatch) | |||
There was a problem hiding this comment.
Does libdispatch use CMake? If not, why is this change needed?
|
Some comments above, but looks reasonable in general. |
|
Thanks for the quick review. Sorry about the indentation; I was using my libdispatch emacs mode (force tabs; tabs are 4 spaces). Need a different mode for foundation... |
|
Thanks. One more place with tabs. My concern about the build mode is that we shouldn't accidentally ship a debug library, and IIRC Autoconf builds in debug by default. We can fix that in a later commit though. |
|
Thanks. I'll look on the dispatch side and see if it needs tweaking to support debug/release build modes in the autoconf driven build. Do you need me to squash & open a new pull request (since this one has gotten a bit messy with the whitespace fixups)? |
|
@dgrove-oss Please squash in-place. |
Extend build-script, build-script-impl, and update-checkout to include libdispatch. For now, libdispatch is not built by default (user must enable via command line argument). Integration of testing is functional, but should be improved in a later pull request. The basic autotools based test harness does not give the nice high-level progress output as the rest of the test suite. A related pull request to libdispatch (#34) has some fixes to the autotools build that are needed to enable the test target to succeed when run in an external directory.
|
squashed in place. Thanks. |
|
Passes tests on Ubuntu 14.04. Merging. |
Initial integration of libdispatch into build-script
Extend build-script, build-script-impl, and update-checkout
to include libdispatch. For now, libdispatch is not
built by default (user must enable via command line
argument).
Integration of testing is functional, but should be improved
in a later pull request. The basic autotools based test
harness does not give the nice high-level progress output
as the rest of the test suite.
A related pull request to libdispatch (#34) has some fixes
to the autotools build that are needed to enable the test
target to succeed when run in an external directory.