Provide clarity around the dependencies of running tests #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… project in README.md
|
This isn't specific to running the tests. You'll need those repos to build swift at all. They're already listed above in "Getting Sources for Swift and Related Projects". |
|
Yeah, that's true. What tripped me up was that there is no indication of what is or isn't required to build swift. Is there a better way to distinguish between required and optional projects in the above list? |
|
It will depend on what you're trying to build, and I don't think we want to break out the minimum dependencies for every use case. The simplest answer is just to clone all the repos. If you care about getting the minimum, you can run |
|
Ahh okay, in light of that response I'll close the PR. |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
Move dispatch_concur and dispatch_readsync to the XFAIL list
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
Adding variable injector as example
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Resolve Sourcery XFAIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it clear to people getting started what projects they need cloned as well as swift in order to build and run the tests.
I've determined this using OSX though haven't determined if the dependencies are the same on Linux. Is anyone able to clarify whether the swift-corelibs-xctest and swift-corelibs-foundation libraries are required in that situation?