Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typo - remove some "and" #179

Closed
wants to merge 1 commit into from
Closed

Conversation

OskarStark
Copy link

No description provided.

@panzarino
Copy link
Contributor

The way that you changed the text actually changed the original meaning of the text. There are some redundant "and"s but you removed some that should not have been removed. I believe that the correct change would be:

Swift is a high-performance system programming language.  It has a clean 
and modern syntax, offers seamless access to existing C and Objective-C code
 and frameworks, and is memory safe (by default).

@OskarStark
Copy link
Author

which meaning did i change? clean and modern ?

@panzarino
Copy link
Contributor

Well the program offers "offers seamless access to existing C and Objective-C code and frameworks" meaning that it offers access to both C code and frameworks and Objective-C code and frameworks. The way you phrased it, "offers seamless access to existing C, Objective-C code, and frameworks," implies that it offers just access to C, includes Objective-C code, and has frameworks on the side. The way that you phrased it completely changes the original meaning of the text.

@davidcbilas
Copy link

The revision could still be improved grammatically and for readability. I would suggest:

Swift is a high-performance system programming language. It has a clean, modern syntax; offers seamless access to existing C and Objective-C code and frameworks; and is memory safe (by default).

@panzarino
Copy link
Contributor

@davidcbilas I agree with that improvement. It is grammatically correct and clarifies the meaning.

@zygoat
Copy link

zygoat commented Dec 4, 2015

The only change necessary in the original text is the removal of the second “and” (before “offers seamless access”), which appears to be what @zachpanz88 proposed in the first comment.

The semicolons offered by @davidcbilas disrupt the readability and offer little value above that provided by commas.

@davidcbilas
Copy link

I would agree with that. My addition of semi-colons were based on the original revision, which had commas within comma-separated clauses.

@lattner
Copy link
Contributor

lattner commented Feb 29, 2016

This conflicts with subsequent changes.

@lattner lattner closed this Feb 29, 2016
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
update libkqueue and libpwq submodules

Signed-off-by: Daniel A. Steffen <[email protected]>
dabelknap pushed a commit to dabelknap/swift that referenced this pull request Jan 8, 2019
Deactivate UseEarlyExits rule; not safe to use
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
…le-attr

[AutoDiff upstream] Update gyb-generated files.
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants