-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typo - remove some "and" #179
Conversation
The way that you changed the text actually changed the original meaning of the text. There are some redundant "and"s but you removed some that should not have been removed. I believe that the correct change would be:
|
which meaning did i change? |
Well the program offers "offers seamless access to existing C and Objective-C code and frameworks" meaning that it offers access to both C code and frameworks and Objective-C code and frameworks. The way you phrased it, "offers seamless access to existing C, Objective-C code, and frameworks," implies that it offers just access to C, includes Objective-C code, and has frameworks on the side. The way that you phrased it completely changes the original meaning of the text. |
The revision could still be improved grammatically and for readability. I would suggest: Swift is a high-performance system programming language. It has a clean, modern syntax; offers seamless access to existing C and Objective-C code and frameworks; and is memory safe (by default). |
@davidcbilas I agree with that improvement. It is grammatically correct and clarifies the meaning. |
The only change necessary in the original text is the removal of the second “and” (before “offers seamless access”), which appears to be what @zachpanz88 proposed in the first comment. The semicolons offered by @davidcbilas disrupt the readability and offer little value above that provided by commas. |
I would agree with that. My addition of semi-colons were based on the original revision, which had commas within comma-separated clauses. |
This conflicts with subsequent changes. |
update libkqueue and libpwq submodules
update libkqueue and libpwq submodules Signed-off-by: Daniel A. Steffen <[email protected]>
Deactivate UseEarlyExits rule; not safe to use
…le-attr [AutoDiff upstream] Update gyb-generated files.
un-XFAIL RxSwift.
No description provided.