Generic pattern emission refactoring #18882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's confusing to have the generic and concrete type metadata builders share a common base class, when most of the base class is not used for the generic case.
…erBase ClassMetadataBuilderBase only has one subclass now, so fold it in.
slavapestov
force-pushed
the
generic-pattern-emission-refactoring
branch
from
ed9f3fd to
d7a9a2a
Compare
slavapestov
changed the title
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
rjmccall
approved these changes
Aug 22, 2018
| NominalTypeDecl *nominalDecl, | ||
| llvm::Value *metadata, | ||
| bool isVWTMutable, | ||
| MetadataDependencyCollector *collector) { |
There was a problem hiding this comment.
Should this be called emitInitializeValueMetadata to make it clear that it's not for classes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Concrete and generic metadata builders shared a base class, but ever since generic metadata patterns became true-const with a layout distinct from instantiated metadata, the generic case no longer uses most of the functionality of the base class.
This is a refactoring in preparation for giving concrete resilient classes a proper true-const pattern.