Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyperlinking essential words #192

Closed
wants to merge 1 commit into from

Conversation

KrishMunot
Copy link
Contributor

No description provided.

@jrose-apple
Copy link
Contributor

Can I ask why this is an improvement? I don't think I've generally seen consistency on this across the internet, and as far as I can see it doesn't make things any clearer.

@KrishMunot
Copy link
Contributor Author

I thought Apple was very specific when it came to details. And I assumed that highlighting the right word would make it look better.
Comparing ourselves to the internet is not right, Apple has its own reputation for being perfect and attention to minute details. This caught my attention and I was distracted by it. So, lets stick to perfection maybe?

@jrose-apple
Copy link
Contributor

Attention to details is good, but I'm still not clear on why "the website" is wrong and "website" is right. Is there an existing style guide that recommends this?

@mxcl
Copy link

mxcl commented Dec 4, 2015

I vote to delegate to @mattt

@KrishMunot
Copy link
Contributor Author

I would definitely not say that "the website" is wrong per se, but aesthetically I believe that when "website" is hyperlinked, it feels that the most relevant keywords have been highlighted, which is a general rule in every style guide.
The addition of "the" to be hyperlinked seems as though very little care was taken during documentation. Two consecutive words are hyperlinked only when they both belong to the same topic (Eg: Apple iPod) or are atleast 2 completely different links. Here, it doesn't match either of the conditions.

@mattt
Copy link
Contributor

mattt commented Dec 4, 2015

@KrishMunot There are currently no formalized conventions on the website with respect to which words to hyperlink. Any lack of internal consistency around usage—such as in the case of this PR—would be better characterized as a variation among individuals rather than any lack of care or attention to detail.

Concerning the convention itself, there are arguments to be made for both including ("website" and "the website" are both noun phrases) and excluding (aesthetics; conciseness) the definite article in the hyperlink text. However, many style guides (like this one) appear to be limited to avoiding the common anti-pattern of "click here", and do not offer further guidance.

If anything, I'd vote to change "the website" to an explicit mention of "Swift.org", as the former is ambiguous (what website? GitHub?).

@KrishMunot
Copy link
Contributor Author

I totally agree with you @mattt . That was a really good style guide and I really learnt something cool today. I have made a new PR with a relevant keyword which is hyperlinked.
Thanks! :)

@mattt
Copy link
Contributor

mattt commented Dec 4, 2015

@KrishMunot Awesome. Thanks for your contribution! Feel free to close this PR if #206 supersedes it.

@KrishMunot KrishMunot closed this Dec 6, 2015
slavapestov pushed a commit to slavapestov/swift that referenced this pull request Nov 27, 2018
…once-more

Replace uses of @_silgen_name with uses of a shims header.
dabelknap added a commit to dabelknap/swift that referenced this pull request Jan 16, 2019
Refactor indentation of control flow statements.
maldahleh pushed a commit to maldahleh/swift that referenced this pull request Oct 26, 2020
freak4pc pushed a commit to freak4pc/swift that referenced this pull request Sep 28, 2022
added xswift groups of projects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants