Me too #194
Closed
Me too #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -153,8 +153,8 @@ A tuple type's access level is the minimum of the access levels of its | |||
| elements. A function type's access level is the minimum of the access levels of | |||
| its input and return types. | |||
|
|
|||
| A typealias may have any access level up to the access level of the type it | |||
| aliases. That is, a ``private`` typealias can refer to an ``public`` type, but | |||
| A type-alias may have any access level up to the access level of the type it | |||
There was a problem hiding this comment.
Isn't typealias (one word) already a Swift keyword? I think this makes sense to leave as-is.
There was a problem hiding this comment.
Apples own documentation breaks it into two words https://developer.apple.com/library/prerelease/ios/documentation/Swift/Conceptual/Swift_Programming_Language/Declarations.html
So if anything the hyphen should be removed.
|
Hm. The compiler's not really consistent with the formal docs on this already, and I'm a little iffy about "type alias" sounding like a general term instead of specifically referring to what you get from a standalone |
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Jan 23, 2019
[Tweaks] Modify control flow wrapping.
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Add 4.2 configuration to project_precommit_check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hyphenated made up words