-
Notifications
You must be signed in to change notification settings - Fork 10.5k
[Swift+WASM] Allow Wasm object format. #20687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Swift+WASM] Allow Wasm object format. #20687
Conversation
- This currently does nothing more than adopt the ELF conventions, but for the Wasm object file format.
Since it seems the most modern wasm triple also sets the wasm object file format (#20684), this is necessary when using that triple. I don't really know the extent to which any of this makes sense, although my impression is that the wasm format is largely following ELF, so I imagine they aren't absolutely horrible defaults to start with exploring. |
@swift-ci please smoke test |
You're going to have to look at |
@compnerd I believe that linking support is under active development, and as you say is only in |
You'll probably want to look at https://github.com/WebAssembly/tool-conventions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about Wasm, but this looks reasonable as a variant of ELF
@ddunbar any updates on this? hope this could be merged soon |
See https://bugs.swift.org/browse/SR-9307 for higher level status. I was wanting to get the Clang change landed first although there is probably no reason not to merge this one |
@swift-ci please smoke test |
Going ahead and merging this to unblock further poking... this will evolve and eventually get tests once enough other pieces are in that an end-to-end test can work. |
Wasm object file format.