[Import as member] Core Graphics #2071
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
ERROR: Couldn't find any revision to build. Verify the repository and branch configuration for this job. |
|
Alright, now that github is functioning normally again, |
|
@swift-ci please test |
|
@swift-ci please test |
|
Ugh, this is failing due to SDK differences and I can't seem to repro right now. I pushed a fix to this specific issue, and now I'll be preparing my machine to be more like the builder's set up. @swift-ci please test |
Fixes a bug where we weren't performing enough checks on inferred computed properties that did not have a pair-ed up setter.
Introduces CoreGraphics.apinotes, in which we enable the import-as-member inference system. Additionally, include some explicit SwiftNames, for when inference doesn't produce the right result, and to aid compatibility with the overlays. Refactors many of the trivial overlays out, shrinking the CoreGraphics.swift overlay by over half. Updates in-tree test cases. The names we currently have will be highly in flux for a while, and are likely to change frequently over the near term. There are a few remaining known bugs that are worked around by apinotes entries.
|
@swift-ci please test |
MaxDesiatov
pushed a commit
that referenced
this pull request
Apr 19, 2021
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
Resolved bug number: (SR-)
Before merging this pull request to apple/swift repository:
Triggering Swift CI
The swift-ci is triggered by writing a comment on this PR addressed to the GitHub user @swift-ci. Different tests will run depending on the specific comment that you use. The currently available comments are:
Smoke Testing
Validation Testing
Note: Only members of the Apple organization can trigger swift-ci.