Document and explain test #225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Document what's going on better, and give things *real* names.
| // We need to know what the internal ID of the buffer is so we can check that only | ||
| // one thread owns a buffer. | ||
| // | ||
| // TODO: explain why we're looking for a specific capacity. |
There was a problem hiding this comment.
This comment is redundant, this interaction is explained later in the code.
|
Sorry, but I don't think this change improves anything. |
dabelknap
added a commit
to dabelknap/swift
that referenced
this pull request
Mar 15, 2019
Update cmark submodule to latest version.
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
Autodiff updates for enabling accessor derivatives …
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Add Evergreen project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Document what's going on better, and give things real names.