enforce readability over preference. #237
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Master and slave are conventions that have stuck with all kinds of technology for years. For someone that's new to the Swift source, the Leader/follower convention makes little sense. I see no reason to change a practice that has been the norm for many years.
|
SlaveString must be slaveString |
|
@phimage I realised this right before you said it, and have fixed it. |
|
just an advice, squash your commit into one if you can, I see this request on other PR |
|
See #218. There's no hierarchical relationship between these threads. |
slavapestov
pushed a commit
to slavapestov/swift
that referenced
this pull request
Nov 27, 2018
tests: adjust printf for size types
dabelknap
pushed a commit
to dabelknap/swift
that referenced
this pull request
Apr 23, 2019
Run 'swift test --generate-linuxmain'
maldahleh
pushed a commit
to maldahleh/swift
that referenced
this pull request
Oct 26, 2020
[readme] Update for 5.3
freak4pc
pushed a commit
to freak4pc/swift
that referenced
this pull request
Sep 28, 2022
Update PinkyPromise hash to 4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Master and slave are conventions that have stuck with all kinds of technology for years. For someone that's new to the Swift source, the Leader/follower convention makes little sense.
I see no reason to change a practice that has been the norm for many years.