[stdlib] Make _parseASCII take radix as Int instead of FixedWidthInteger #26961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentyrone
requested changes
Sep 6, 2019
| ) -> Result? | ||
| where CodeUnits.Element: UnsignedInteger { | ||
| let c0_ = codeUnits.next() | ||
| guard _fastPath(c0_ != nil), let c0 = c0_ else { return nil } | ||
| if _fastPath(c0 != _ascii16("+") && c0 != _ascii16("-")) { | ||
| return _parseUnsignedASCII( | ||
| first: c0, rest: &codeUnits, radix: radix, positive: true) | ||
| first: c0, rest: &codeUnits, radix: radix, positive: true) as? Result |
There was a problem hiding this comment.
This is a clear indication that this is not a full solution; _parseUnsignedASCII should still be returning a Result, so this cast shouldn't be necessary.
There was a problem hiding this comment.
@theblixguy Looks to me like you'll need to propagate the radix: Result -> radix: Int change throughout all the internal methods in this file.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
_parseASCIItake theradixparameter asIntinstead ofResult(akaFixedWidthInteger).(I've never contributed towards the Standard Library before, so please let me know if you have any feedback!)
Resolves SR-11397.