Skip to content

[SyntaxParse] Re-apply associatedtype decl parsing #27416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 1, 2019
Merged

[SyntaxParse] Re-apply associatedtype decl parsing #27416

merged 3 commits into from
Oct 1, 2019

Conversation

rintaro
Copy link
Member

@rintaro rintaro commented Sep 28, 2019

With fixes.

  1. Revert Revert "[SyntaxParse] Parse associatedtype decl" #27363
  2. Fix round-trip issue in consecutive ID diagnostics
  3. Fix Memory leak rdar://problem/55712090

@rintaro rintaro mentioned this pull request Sep 28, 2019
Merged
@rintaro
Copy link
Member Author

rintaro commented Sep 28, 2019

swiftlang/swift-syntax#145
@swift-ci Please test

@rintaro
Copy link
Member Author

rintaro commented Sep 30, 2019

@swift-ci Please ASAN test

@rintaro rintaro merged commit 5726179 into swiftlang:master Oct 1, 2019
@rintaro rintaro deleted the syntaxparse-declassociatedtype branch October 1, 2019 16:56
rintaro added a commit to swiftlang/swift-syntax that referenced this pull request Oct 1, 2019
@rintaro
Merge pull request #145 from rintaro/typealias-as-associatedtype
5bfc40b 
Update coloring test for swiftlang/swift#27416
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Merge pull request swiftlang#27416 from rintaro/syntaxparse-d…
fbc7c6c 
…eclassociatedtype"

This reverts commit 5726179, reversing
changes made to d5adbe2.
rintaro added a commit to rintaro/swift that referenced this pull request Oct 14, 2019
@rintaro
Revert "Revert "Merge pull request swiftlang#27416 from rintaro/synta…
423bd6b 
…xparse-declassociatedtype""

This reverts commit fbc7c6c.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rintaro