Skip to content

[semantic-arc-opts] Convert isDeadLiveRange into a method on a general LiveRange class. #28656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Dec 9, 2019

In a forthcoming commit, I am going to need access to the "escaping" uses of a
dead live range. Rather than add /another/ argument to isDeadLiveRange, this
commit refactors the code to be a constructor on a general LiveRange class that
internally contains the lists of destroys, forwarding instructions we can
convert to be guaranteed, and consuming instructions that we do not understand.

Should be NFC.

@gottesmm gottesmm requested a review from atrick December 9, 2019 20:10
@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 9, 2019

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

gottesmm commented Dec 9, 2019

I forgot to merge in another fix commit.

@gottesmm gottesmm force-pushed the pr-1b805643ed16875a451d67e7554f321977df32bf branch from 8e31c3c to b1fb2f2 Compare December 9, 2019 21:21
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

…l LiveRange class.

In a forthcoming commit, I am going to need access to the "escaping" uses of a
dead live range. Rather than add /another/ argument to isDeadLiveRange, this
commit refactors the code to be a constructor on a general LiveRange class that
internally contains the lists of destroys, forwarding instructions we can
convert to be guaranteed, and consuming instructions that we do not understand.

Should be NFC.
@gottesmm gottesmm force-pushed the pr-1b805643ed16875a451d67e7554f321977df32bf branch from b1fb2f2 to f236e0f Compare December 10, 2019 00:17
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

3 similar comments
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

Python lint error...

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test os x platform

1 similar comment
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test os x platform

@gottesmm gottesmm merged commit 678a707 into swiftlang:master Dec 10, 2019
@gottesmm gottesmm deleted the pr-1b805643ed16875a451d67e7554f321977df32bf branch December 10, 2019 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant