Skip to content

[AutoDiff] NFC: @differentiable attribute gardening. #28666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

[AutoDiff] NFC: @differentiable attribute gardening. #28666

merged 1 commit into from
Dec 10, 2019

Conversation

dan-zheng
Copy link
Contributor

  • Move DifferentiableAttr definition above DeclAttributes in
    include/swift/AST/Attr.h, like other attributes.
  • Remove unnecessary arguments from DifferentiableAttr::DifferentiableAttr
    and DifferentiableAttr::setDerivativeGenericSignature.
  • Add libSyntax test for @differentiable attributes.

Makes DifferentiableAttr more in sync with tensorflow branch version.

@dan-zheng dan-zheng requested review from rxwei and bgogul December 9, 2019 23:40
@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 29782127cd3c0a21c77de883434ea6c5425ea8b1

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 29782127cd3c0a21c77de883434ea6c5425ea8b1

@dan-zheng
[AutoDiff] NFC: @differentiable attribute gardening.
a5a9c5b 
- Move `DifferentiableAttr` definition above `DeclAttributes` in
  include/swift/AST/Attr.h, like other attributes.
- Remove unnecessary arguments from `DifferentiableAttr::DifferentiableAttr`
  and `DifferentiableAttr::setDerivativeGenericSignature`.
- Add libSyntax test for `@differentiable` attributes.
@dan-zheng
Copy link
Contributor Author

I forgot to check in test/AutoDiff/Syntax/Outputs/round_trip_parse_gen.swift.withkinds, sorry.

@dan-zheng
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 29782127cd3c0a21c77de883434ea6c5425ea8b1

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 29782127cd3c0a21c77de883434ea6c5425ea8b1

@dan-zheng dan-zheng merged commit 6742368 into swiftlang:master Dec 10, 2019
@dan-zheng dan-zheng deleted the autodiff-gardening branch December 10, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rxwei rxwei rxwei approved these changes

@bgogul bgogul Awaiting requested review from bgogul

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dan-zheng @swift-ci @rxwei