[CSDiag] Start chipping away at FailureDiagnosis::diagnoseAmbiguity #29415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
Next to go is ambiguity due to unresolved member references for cases like: func f(_: Int) {}
func f(_: String) {}
f(.nothing)Currently working on generalizing the strategy in |
xedin
reviewed
Jan 24, 2020
xedin
approved these changes
Jan 24, 2020
xedin
reviewed
Jan 24, 2020
| .highlight(E->getSourceRange()); | ||
| return; | ||
| } | ||
|
|
||
| // Diagnose ".foo" expressions that lack context specifically. | ||
| if (auto UME = | ||
| dyn_cast<UnresolvedMemberExpr>(E->getSemanticsProvidingExpr())) { |
There was a problem hiding this comment.
Btw, I think this should be obsolete as well because diagnostics for _ = .foo have been ported already as missing base type for unresolved member.
There was a problem hiding this comment.
It isn't yet :/ it's still handling cases like this, where the solver does find multiple solutions with fixes but it isn't yet diagnosed in diagnoseAmbiguityWithFixes :
func f(_: Int) {}
func f(_: String) {}
f(.nothing)I'm currently working on this case though!
There was a problem hiding this comment.
Ah, that comment on top threw me off :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove some special cases in
FailureDiagnosis::diagnoseAmbiguity, including:_. Find solutions using holes for the type of the invalid underscore.