[WASM] [BuildScript] Initial Support for building WASI toolchain #29465
Conversation
kateinoigakukun
force-pushed
the
katei/swasm/build-script
branch
2 times, most recently
from
fb2d12b to
cc75c28
Compare
|
Does this work conflict your recent work @compnerd ? |
|
@kateinoigakukun yes, it does. Also, please don't create large stacks of commits in a single PR, it makes it more difficult to review. |
kateinoigakukun
force-pushed
the
katei/swasm/build-script
branch
from
40e6fd8 to
d348a40
Compare
|
@compnerd OK, I fixed up them in 1 commit |
|
Hi @compnerd, would you be able to have another look at this PR? Thank you and much appreciated! |
|
Hi @gribozavr @CodaFi would you be able to help with reviewing this PR? Or could you redirect to someone else more appropriate? Thank you 🙏 |
|
The changes look good to me, but since I haven't touched the build system in a couple of years, I don't think my review in this area counts much. @compnerd ? |
kateinoigakukun
force-pushed
the
katei/swasm/build-script
branch
3 times, most recently
from
09e952d to
047ab39
Compare
kateinoigakukun
force-pushed
the
katei/swasm/build-script
branch
from
047ab39 to
af049c8
Compare
|
@compnerd I minimized |
| @@ -153,6 +153,7 @@ KNOWN_SETTINGS=( | |||
| skip-test-osx "" "set to skip testing Swift stdlibs for OS X" | |||
| skip-test-tvos-host "" "set to skip testing the host parts of the tvOS toolchain" | |||
| skip-test-tvos-simulator "" "set to skip testing Swift stdlibs for tvOS simulators (i.e. test devices only)" | |||
| skip-test-wasi "" "set to skip testing Swift stdlibs for WebAssembly/WASI" | |||
There was a problem hiding this comment.
should there be a matching skip-build-wasi somewhere as well?
|
We've already merged a lot of parts in this PR step by step, so close now |
This PR adds WASI toolchain variant to port our WebAssembly support, step by step.
This is a part of SR-9307 and #24684.