Skip to content

Revert "build: simplify version tracking logic" #29545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 30, 2020
Merged

Revert "build: simplify version tracking logic" #29545

merged 1 commit into from
Jan 30, 2020

Conversation

shahmishal
Copy link
Member

Reverts #29040

@shahmishal
Copy link
Member Author

@swift-ci build toolchain macOS

@swift-ci
Copy link
Contributor

macOS Toolchain
Download Toolchain
Git Sha - be37141

Install command
tar -zxf swift-PR-29545-478-osx.tar.gz --directory ~/

@shahmishal
Copy link
Member Author 

swift-PR-29545-478.xctoolchain/usr/bin/swift --version
Apple Swift version 5.2-dev (Swift 07fbd2abd5)
Target: x86_64-apple-darwin18.6.0

Going to revert the change to get the SHA back in the version.

@shahmishal
Copy link
Member Author

@swift-ci smoke test

@shahmishal shahmishal requested a review from compnerd January 30, 2020 18:55
@shahmishal shahmishal merged commit a34b044 into master Jan 30, 2020
@shahmishal shahmishal deleted the revert-29040-version-control branch January 30, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd Awaiting requested review from compnerd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shahmishal @swift-ci