Skip to content

Revert "Revert "build: simplify version tracking logic"" #29583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 1, 2020

Conversation

compnerd
Copy link
Member

@compnerd compnerd commented Feb 1, 2020

This reverts commit be37141. Add a
small fix in the dereferencing.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

This reverts commit be37141.  Add a
small fix in the dereferencing.
@compnerd
Copy link
Member Author

compnerd commented Feb 1, 2020

CC: @shahmishal

@compnerd
Copy link
Member Author

compnerd commented Feb 1, 2020

@swift-ci please smoke test

@compnerd
Copy link
Member Author

compnerd commented Feb 1, 2020

@swift-ci please build macOS toolchain

@shahmishal
Copy link
Member

@swift-ci please build toolchain macOS

@swift-ci
Copy link
Contributor

swift-ci commented Feb 1, 2020

macOS Toolchain
Download Toolchain
Git Sha - ab5c682

Install command
tar -zxf swift-PR-29583-479-osx.tar.gz --directory ~/

@compnerd
Copy link
Member Author

compnerd commented Feb 1, 2020

$ usr/bin/swiftc --version
Apple Swift version 5.2-dev (LLVM 312410efca, Swift 1602d65dc2)

Seems good @shahmishal?

@shahmishal
Copy link
Member

Thanks!!

@shahmishal shahmishal merged commit 2c018ce into swiftlang:master Feb 1, 2020
@compnerd compnerd deleted the try-try-try-again branch February 1, 2020 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants