[Type checker] Clean up expression type checking flags #29589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This flag is recoverable from the contextual type purpose; don’t duplicate the logic.
This is always set along with SubExpressionDiagnostics, so use that for both purposes. That flag will go away when `CSDiag.cpp` goes away.
A contextual type purpose, that is, so it captures more about what the entity is that is being solved.
|
@swift-ci please smoke test and merge |
xedin
approved these changes
Feb 1, 2020
| @@ -641,7 +641,7 @@ bool GenericArgumentsMismatchFailure::diagnoseAsError() { | |||
| switch (last.getKind()) { | |||
| case ConstraintLocator::ContextualType: { | |||
| auto purpose = getContextualTypePurpose(); | |||
| assert(!(purpose == CTP_Unused && purpose == CTP_CannotFail)); | |||
| assert(!(purpose == CTP_Unused || purpose == CTP_CannotFail)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
TypeCheckExprFlagsenum has amassed a few flags that are either redundant (because they can be computed from other information) or simply unused. Remove them.