Skip to content

[WebAssembly] Fix a few tests for WASI #29871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

MaxDesiatov
Copy link
Contributor

Disables/enables stdlib testing code appropriately when targeting WebAssembly/WASI.

This is a part of SR-9307 and #24684.

(cc @kateinoigakukun)

@gribozavr
Copy link
Contributor

@swift-ci Please test and merge

@MaxDesiatov MaxDesiatov removed the request for review from drodriguez February 17, 2020 15:15
@compnerd
Copy link
Member

I really would prefer that you didn't do this change. WASI uses musl, not glibc, and there are user visible differences between the implementations. This is going to cause problems.

@MaxDesiatov
Copy link
Contributor Author

@compnerd I can close the PR for now, but has anyone tried to support musl in the Swift infrastructure yet? Would a better approach be to support musl on say Linux directly before attempting to support it for the WASI target?

@kateinoigakukun
Copy link
Member

@compnerd Do you mean we should replace these import statements with import Musl to match library name and actual library content?

@MaxDesiatov
Copy link
Contributor Author

@kateinoigakukun Yes, that's would work best in my opinion too. Would be easiest to set this up for Linux first I think, I'm trying to build everything on Alpine to verify this.

@MaxDesiatov
Copy link
Contributor Author

MaxDesiatov commented Feb 18, 2020

@compnerd this one will be either reverted or superseded with import Musl change that I'm actively working on right now. Sorry, wasn't sure if CI was actually stuck and whether it was going to merge it at all.

@MaxDesiatov MaxDesiatov deleted the swiftwasm-stdlib-tests branch February 18, 2020 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants