Skip to content

Temporarily disable 3 AutoDiff tests: SR-12732 #31545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2020

Conversation

atrick
Copy link
Contributor

@atrick atrick commented May 4, 2020

https://bugs.swift.org/browse/SR-12732
3 AutoDiff test failures: crashing in SIL verification

Failing Tests (3):
06:26:12 Swift(macosx-x86_64) :: AutoDiff/validation-test/derivative_registration.swift
06:26:12 Swift(macosx-x86_64) :: AutoDiff/validation-test/custom_derivatives.swift
06:26:12 Swift(macosx-x86_64) :: AutoDiff/stdlib/derivative_customization.swift

Possibly from:

commit 738ef73
Author: Dan Zheng [email protected]
Date: Mon May 4 00:44:48 2020 -0700

[AutoDiff] Fix `@differentiable` attribute derivative configurations. (#31524)

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

https://bugs.swift.org/browse/SR-12732
3 AutoDiff test failures: crashing in SIL verification

Failing Tests (3):
06:26:12     Swift(macosx-x86_64) :: AutoDiff/validation-test/derivative_registration.swift
06:26:12     Swift(macosx-x86_64) :: AutoDiff/validation-test/custom_derivatives.swift
06:26:12     Swift(macosx-x86_64) :: AutoDiff/stdlib/derivative_customization.swift

Possibly from:

commit 738ef73
Author: Dan Zheng <[email protected]>
Date:   Mon May 4 00:44:48 2020 -0700

    [AutoDiff] Fix `@differentiable` attribute derivative configurations. (swiftlang#31524)
@atrick atrick requested a review from dan-zheng May 4, 2020 21:36
@atrick
Copy link
Contributor Author

atrick commented May 4, 2020

@swift-ci smoke test and merge

Copy link
Contributor

@dan-zheng dan-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, sorry about the failures!

@swift-ci swift-ci merged commit 94a7af4 into swiftlang:master May 5, 2020
@atrick atrick deleted the disabled-autodiff-tests branch May 7, 2020 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants