[IRGen] Introduce OptimizedIRRequest #32914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will avoid needing to recreate it when we come to perform LLVM passes.
This will allow it to better interact with the SILGen descriptor.
The LLVM passes we apply don't depend on the language version, only the compiler version.
This seems like something we want to always do, not just when emitting the LLVM module.
Factor out the logic that deals with the LLVM passes for compiling and emitting the module.
Remove the side-effecting call from IRGenRequest, instead requiring callers to handle the optimization and emission of the LLVM module.
Introduce a request that wraps the entire compiler pipeline and returns the optimized IR for a whole-module or file.
|
@swift-ci please test source compatibility |
CodaFi
approved these changes
Jul 16, 2020
|
@swift-ci please test |
hamishknight
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jul 16, 2020
hamishknight
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Jul 21, 2020
[master-rebranch] Update for swiftlang/swift#32914
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a request that returns the optimized IR for a whole-module or file, and use it in SILLLVMGen. For now this manually wraps the entire compiler pipeline, but eventually will be able to just call into IRGen.