[5.3][stdlib] Make _convertConstStringToUTF8PointerArgument transparent #32929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
airspeedswift
changed the title
DougGregor
approved these changes
Jul 16, 2020
|
@swift-ci nominate |
AnthonyLatsis
added
swift 5.3
🍒 release cherry pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was not marked as inlineable, which prevents specialization and caused code using it to add resilient caches for the
_Pointerprotocol into the DATA segment. The unspecialized code is also less efficient.Cherry-pick of #32915
Scope of Issue: This is causing unspecialized code on pointer manipulation, which dirties memory and bloats code size.
Origination: This has been like this since the standard library became resilient
Risk: Extremely low, this is just exposing trivial code to the inline
Test: use is covered by several existing tests
Reviewed by: @lorentey
Resolves: rdar://65640613