Skip to content

[WIP] Disable -disable-concrete-type-metadata-mangled-name-accessors flag. #33689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

jckarter
Copy link
Contributor

With the improvements to protocol casting performance from #33487, experiment to see if the demangling overhead is manageable for people using this flag today.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e23c27865ef1ba34021192da03e03f56accadb68

With the improvements to protocol casting performance from swiftlang#33487, the demangling overhead is
hopefully manageable for most people using this flag today.
@jckarter jckarter force-pushed the disable-disable-mangled-name-accessors branch from e23c278 to 2a1c992 Compare August 28, 2020 23:44
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - e23c27865ef1ba34021192da03e03f56accadb68

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - e23c27865ef1ba34021192da03e03f56accadb68

@shahmishal
Copy link
Member

Please update the base branch to main by Oct 5th otherwise the pull request will be closed automatically.

  • How to change the base branch: (Link)
  • More detail about the branch update: (Link)

@shahmishal shahmishal closed this Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants