Skip to content

[docs] Minor revision of trailing closure matching educational note #33834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 7, 2020

Conversation

xwu
Copy link
Collaborator

@xwu xwu commented Sep 6, 2020

Belatedly coming to the educational note on trailing closure matching. This is a revision that principally reorganizes the information.

  • The bit about the warning when forwards and backwards scans produce different results is pretty key, as it's likely to be the reason that users encounter this note; therefore, move that above the details about the forward scanning rule and insert a bit about how to silence this warning.

  • Insert a brief summary about the forward scanning rule's detailed implementation upfront, and only for people that need the details, provide the nitty gritty definitions in their own sections afterwards.

@xwu xwu requested review from owenv and xedin September 6, 2020 20:46
@xwu
Copy link
Collaborator Author

xwu commented Sep 6, 2020

@owenv Sorry that I couldn't get to reviewing #33119 before it was merged. Here are some changes I had in mind after looking through the document.

Copy link
Contributor

@owenv owenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

Copy link
Contributor

@xedin xedin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Once that typo in label, @3405691582 has noticed, is fixed everything should be good to go.

@xedin
Copy link
Contributor

xedin commented Sep 7, 2020

@xwu let me know if you need help with kicking off CI and merging...

@xwu
Copy link
Collaborator Author

xwu commented Sep 7, 2020

@swift-ci smoke test and merge

1 similar comment
@xwu
Copy link
Collaborator Author

xwu commented Sep 7, 2020

@swift-ci smoke test and merge

@swift-ci swift-ci merged commit 8c2e423 into swiftlang:master Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants