Skip to content

[Reflection] Support OpaqueExistential in RecordTypeInfo::readExtraInhabitantIndex #35497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 21, 2021
Merged

[Reflection] Support OpaqueExistential in RecordTypeInfo::readExtraInhabitantIndex #35497

merged 5 commits into from
Jan 21, 2021

Conversation

kastiglione
Copy link
Contributor

Cherry-pick #35433 to 5.4.

This fills in missing support for OpaqueExistential in
RecordTypeInfo::readExtraInhabitantIndex.

Unblocks rdar://68171421

kastiglione and others added 4 commits January 19, 2021 15:05
@kastiglione
[Reflection] Support OpaqueExistential in RecordTypeInfo::readExtraIn…
7d7ca74 
…habitantIndex

(cherry picked from commit 1e58387)
@kastiglione
add reflect_Optional_Any.swift
748437e 
Authored by Tim Kientzle @tbkka

(cherry picked from commit 340b85f)
@kastiglione
test fixes
72fc91a 
(cherry picked from commit 7ed7122)
@tbkka @kastiglione
More test adjustments
bc918f4 
(cherry picked from commit cb1173d)
@kastiglione kastiglione requested a review from a team as a code owner January 19, 2021 23:10
@kastiglione
Copy link
Contributor Author

@swift-ci test

@kastiglione kastiglione requested review from tbkka and fredriss January 20, 2021 19:02
@davezarzycki @kastiglione
[Testing] Unbreak unified build testing
1b38159 
This test assumes an Apple platform but for reasons unknown, the Linux
bots (wrongly?) consider this test to be unsupported.

(cherry picked from commit ab2f6c7)
@kastiglione
Copy link
Contributor Author

@swift-ci test

tbkka
tbkka approved these changes Jan 20, 2021
View reviewed changes
Copy link
Contributor

@tbkka tbkka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll try to get the test fixed on Linux shortly.

@kastiglione kastiglione merged commit d864e95 into release/5.4 Jan 21, 2021
@kastiglione kastiglione deleted the Reflection-Support-OpaqueExistential-in-RecordTypeInfo-readExtraInhabitantIndex-release-5.4 branch January 21, 2021 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredriss fredriss fredriss approved these changes

@tbkka tbkka tbkka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kastiglione @fredriss @tbkka @davezarzycki