Add static library configuration for _InternalSwiftSyntaxParser #36151
Conversation
When building command line tools that depend on SwiftSyntax, statically linking this library can be preferred to produce a more portable binary that doesn't directly depend on the system installation. Currently you can achieve this benefit by shipping the dylib with your tool, and editing the rpaths to prefer yours, but that's a lot of trouble.
| @@ -10,14 +10,24 @@ set(LLVM_EXPORTED_SYMBOL_FILE | |||
| add_swift_host_library(libSwiftSyntaxParser SHARED | |||
| c-include-check.c | |||
| libSwiftSyntaxParser.cpp) | |||
|
|
|||
| add_swift_host_library(libSwiftSyntaxParserStatic STATIC | |||
There was a problem hiding this comment.
I don't feel great about all this duplication, but also since only ~half of the things here applied to this, I went with it over creating a function. I'm not a cmake expert so I'd appreciate input!
| endif() | ||
|
|
||
| add_dependencies(parser-lib libSwiftSyntaxParser) | ||
| add_dependencies(parser-lib libSwiftSyntaxParserStatic) |
There was a problem hiding this comment.
I'm not sure what adding this as a dependency here is for
| swift_install_in_component(TARGETS libSwiftSyntaxParser | ||
| ARCHIVE DESTINATION "lib${LLVM_LIBDIR_SUFFIX}/swift/${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}" COMPONENT parser-lib | ||
| LIBRARY DESTINATION "lib${LLVM_LIBDIR_SUFFIX}/swift/${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}" COMPONENT parser-lib | ||
| RUNTIME DESTINATION "bin" COMPONENT parser-lib) | ||
| swift_install_in_component(TARGETS libSwiftSyntaxParserStatic | ||
| ARCHIVE DESTINATION "lib${LLVM_LIBDIR_SUFFIX}/swift/${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}" COMPONENT parser-lib | ||
| LIBRARY DESTINATION "lib${LLVM_LIBDIR_SUFFIX}/swift/${SWIFT_SDK_${SWIFT_HOST_VARIANT_SDK}_LIB_SUBDIR}" COMPONENT parser-lib |
There was a problem hiding this comment.
I'm hoping this translates to being included in produced toolchains so it could be shipped with releases, but I'm not sure if I should build one of those to see, or if it needs to also be added below
|
@swift-ci please test |
|
Can you trigger the toolchain build just so we can see how this affects that? |
|
@swift-ci Please Build Toolchain Linux Platform |
|
@swift-ci Please Build Toolchain macOS Platform |
|
Hrm so I just discovered that I don't think this is enough to be portable, we actually need a "fully linked" static library (bazel terminology, I can't find an analogy in cmake) where all the dependent libraries are included in this output as well. |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
So I found a hack that works here where I pretend the library is a dynamic library, and then manually pass |
|
I'd be really interested how fully linking of the static libs works as well. Maybe some can help out here? :) |
|
I got a bit further by using a custom target to combine libraries, but that doesn't play well with the rest of the build system that expects some specific types of targets. Related cmake feature request https://gitlab.kitware.com/cmake/cmake/-/issues/20858 |
keith
deleted the
ks/add-static-library-configuration-for-_internalswiftsyntaxparser
branch
When building command line tools that depend on SwiftSyntax, statically
linking this library can be preferred to produce a more portable binary
that doesn't directly depend on the system installation. Currently you
can achieve this benefit by shipping the dylib with your tool, and
editing the rpaths to prefer yours, but that's a lot of trouble.
Fixes https://bugs.swift.org/browse/SR-14001 and probably https://bugs.swift.org/browse/SR-9038