[SyntaxParser] Split definition of C data types into separate file #39441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To split the SwiftSyntax library into two modules – `SwiftSyntax` with no dependency on `_InternalSwiftSyntaxParser.dylib` and `SwiftSyntaxParser` which generates a `SwiftSyntax` tree using `_InternalSwiftSyntaxParser.dylib` – we need to copy the definition of the C types into the SwiftSyntax repository. To make sure the two match, move the duplicated types into their own file. That way, we can compare them in SwiftSyntax’s build script and thus make sure their definitions are the same.
|
@swift-ci Please smoke test |
vivekg-ai
added a commit
to vivekg-ai/swift-build
that referenced
this pull request
Feb 23, 2022
The PR swiftlang/swift#39441 has split the SwiftSyntaxParser.h into two parts - * SwiftSyntaxCDataTypes.h * SwiftSyntaxParser.h The generated snapshot binaries are missing `SwiftSyntaxCDataTypes.h` header. This is causing a build failure for a sample using SwiftSyntax on Windows.
compnerd
added a commit
to compnerd/swift-installer-scripts
that referenced
this pull request
Feb 23, 2022
This repairs the toolchain manifest after swiftlang/swift#39441 which split the header into two files. This ensures that both halves are packaged.
vivekg-ai
added a commit
to vivekg-ai/swift-build
that referenced
this pull request
Feb 23, 2022
The PR swiftlang/swift#39441 has split the SwiftSyntaxParser.h into two parts - * SwiftSyntaxCDataTypes.h * SwiftSyntaxParser.h Include this file SwiftSyntaxCDataTypes.h from release 5.6+
compnerd
pushed a commit
to compnerd/swift-build
that referenced
this pull request
Feb 23, 2022
* Include SwiftSyntaxCDataTypes.h in snapshot binary The PR swiftlang/swift#39441 has split the SwiftSyntaxParser.h into two parts - * SwiftSyntaxCDataTypes.h * SwiftSyntaxParser.h Include this file SwiftSyntaxCDataTypes.h from release 5.6+ Add the necessary plumbing via HAVE__INTERNAL_SWIFT_SYNTAX_CTYPES_HEADER Ensure that this flag is set for the releases 5.6 onwards Co-authored-by: Vivek <[email protected]>
compnerd
added a commit
to swiftlang/swift-installer-scripts
that referenced
this pull request
Feb 23, 2022
This repairs the toolchain manifest after swiftlang/swift#39441 which split the header into two files. This ensures that both halves are packaged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Companion of swiftlang/swift-syntax#309
To split the SwiftSyntax library into two modules –
SwiftSyntaxwith no dependency on_InternalSwiftSyntaxParser.dylibandSwiftSyntaxParserwhich generates aSwiftSyntaxtree using_InternalSwiftSyntaxParser.dylib– we need to copy the definition of the C types into the SwiftSyntax repository. To make sure the two match, move the duplicated types into their own file. That way, we can compare them in SwiftSyntax’s build script and thus make sure their definitions are the same.