[AST] Preserve source location in packIntoImplicitTupleOrParen #39522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When type-checking a tuple construction such as `Void()`, make sure to preserve the source info from the argument list in the resulting type-checked TupleExpr `()`. This is needed for serialization to be able to grab the textual representation. SR-15181 rdar://83202870
|
@swift-ci please test |
xymus
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a crash introduced by the ArgumentList refactoring. When type-checking a tuple construction such as
Void(), make sure to preserve the source info from the argument list in the resulting type-checked TupleExpr(). This is needed for serialization to be able to grab the textual representation.Note that we still need to do more here to fully preserve the entire tuple construction expression in case the destination tuple type has important contextual information such as
(Substring, Substring)("", ""). I've filed SR-15264 to track that, as I'm not entirely sure whether or not it has compatibility implications. This patch should at least get us back to the behavior prior to the ArgumentList refactoring though.SR-15181
rdar://83202870