skip implicit clang decls in the duplicate-decl assertion #41115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SR-15801 rdar://88299954
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
This was referenced Feb 1, 2022
|
@swift-ci Please build toolchain macOS platform |
|
@swift-ci Please build toolchain macOS platform |
|
Source compatibility seems to be an issue on the CI builder, and/or an issue in SwiftPM. Trying with the SwiftPM fix... swiftlang/swift-package-manager#4075 @swift-ci Please test source compatibility |
|
macOS Toolchain Install command |
|
cc @slavapestov since you reviewed the past patches in this series |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test |
slavapestov
approved these changes
Feb 18, 2022
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves SR-15801
The "duplicate decls" assertion added in #40810 (and re-added in #40860) trips on modules that re-export multiple modules that themselves have underlying Clang modules. This is because of decls added implicitly by Clang, such as
__NSConstantString. These duplicate decls should be harmless to leave in, since they are usually filtered out by consumers ofgetDisplayDeclsanyway.I'm not totally sure this is the right approach, but these decls aren't as clear-cut as "importing multiple copies of the same underlying module", so i'm posting this as a potential solution and i would like to run as many tests as possible to make sure that my assumptions are correct.