Fix typos #56
Merged
Fix typos #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Goles
commented
Dec 3, 2015
Goles
commented
- overridding should be overriding.
| @@ -211,7 +211,7 @@ bridged to NSArray, use ContiguousArray instead of Array: | |||
| class C { ... } | |||
| var a: ContiguousArray<C> = [C(...), C(...), ..., C(...)] | |||
|
|
|||
| Advice: Use inplace mutation instead of object-reassignment | |||
There was a problem hiding this comment.
'inplace' is a term. The other changes look fine.
|
IMO it would be better to squash the commits into one single commit. |
|
Yes please squash into a single commit. |
|
@krememek sorry for not doing it earlier, took a while to pull the whole repo and Github didn't allow me to squash 👍 |
dabelknap
pushed a commit
to dabelknap/swift
that referenced
this pull request
Aug 2, 2018
dabelknap
pushed a commit
to dabelknap/swift
that referenced
this pull request
Sep 17, 2018
DougGregor
pushed a commit
to DougGregor/swift
that referenced
this pull request
Apr 28, 2024
Fix the shared metadata location to match new dir layout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.