Skip to content

Cede Ownership of Swift Attributes to swift-syntax #60974

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

CodaFi
Copy link
Contributor

@CodaFi CodaFi commented Sep 7, 2022

Replace Attr.def with a gyb file that reads from swift-syntax to automatically generate the attribute nodes.

For now, only the Swift attributes have been migrated. SIL attributes can be defined manually in Attr.def.gyb. To add new Swift attributes, a paired pull request to swift-syntax is now necessary.

@CodaFi CodaFi force-pushed the attributes branch 4 times, most recently from 8389474 to 90c1782 Compare September 13, 2022 21:17
Replace Attr.def with a gyb file that reads from swift-syntax
to automatically generate the attribute nodes.

For now, only the Swift attributes have been migrated. SIL attributes
can be defined manually in Attr.def.gyb. To add new Swift attributes,
a paired pull request to swift-syntax is now necessary.
@CodaFi CodaFi marked this pull request as ready for review September 14, 2022 00:30
@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 14, 2022

@swift-ci test

@CodaFi
Copy link
Contributor Author

CodaFi commented Sep 14, 2022

@swift-ci smoke test

@CodaFi CodaFi merged commit 435af14 into swiftlang:main Sep 14, 2022
@CodaFi CodaFi deleted the attributes branch September 14, 2022 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant