Adapt memberOf Relationships Stemming from Default Implementations to Extension Block Symbol Format
#61406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theMomax
force-pushed
the
extension-block-symbols-default-implementation-relationship
branch
from
9f65ff2 to
15c8045
Compare
test/SymbolGraph/Relationships/DefaultImplementationOf/External.swift
Outdated
Show resolved
Hide resolved
…tension block symbol if extension block symbol format is used
theMomax
force-pushed
the
extension-block-symbols-default-implementation-relationship
branch
from
15c8045 to
00584ce
Compare
QuietMisdreavus
approved these changes
Nov 15, 2022
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #59047. It completes the implementation of the Extension Block Symbol Format by moving the target of
memberOfthat stem from default implementations to the extension block symbol. Of course, this only applies if the-emit-extension-block-symbolsflag is used.As
memberOfrelationships could already appear onswift.extensionsymbols prior to this commit, the Symbol Graph Format Version does not need to be increased and no change to apple/swift-docc is required.This is the last change to the actual symbol graph generation logic required to resolve swiftlang/swift-docc#210.
A first follow-up PR will add a CLI flag for explicitly disabling the Extension Block Symbol Format and list the feature in lib/Option/features.json. A second and final follow-up PR will eventually make the Extension Block Symbol Format the default behavior.