Add a fast-path case for enumeration of keys and objects for bridged Dictionaries #6421
Conversation
|
@swift-ci please test |
|
|
||
| @objc(enumerateKeysAndObjectsWithOptions:usingBlock:) | ||
| internal func enumerateKeysAndObjects(options: Int, | ||
| using block: @convention(block) (Unmanaged<AnyObject>, Unmanaged<AnyObject>, |
There was a problem hiding this comment.
I believe you can leave out the Unmanaged here; it's understood that blocks take arguments at +0.
There was a problem hiding this comment.
I will take a look at that tomorrow to verify the behavior is correct per Foundation changes
There was a problem hiding this comment.
Ping! I was just looking at this again over the weekend, and this would be a huge win
|
I thought I had merged this already, the required changes for Foundation have already landed so this will now be an applicable improvement going forward. |
|
Ah, in the future can you retest when merging something so old? I can't see how this particular patch would cause any harm but just in case. |
|
Ok will do. |
This adds a fast-path accessor for enumeration of the bridged representation of Dictionaries such that Foundation can take advantage of that particular fast-path when bridging property list types
Custom benchmark of profiling 10000 property lists from /Applications shows that the average time per plist to convert back to data before this change is approximately 0.019s on the machine I tested with. After the change (with the corresponding Foundation change) it is approximately 0.0094s (mileage and exact numbers subject to change per hardware). This will not be in effect until Foundation fully adopts the proposed changes required for taking advantage of this as a fast-path (so no current benchmarks should show any markable difference)