Compile time improvements in the Swift optimizer #64359
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
The run time of `Value.hasTrivialNonPointerType` is not negligible, because it does a cache lookup of type lowerings. Only do this check if it's really needed.
Instead of doing the type casts and/or conformance lookup on the swift side, do it on the C++ side. It makes a significant performance difference because `Operand.value` is a time critical function
…e SIL objects. Looking at the SIL I came to the conclusion that `Unmanaged` ins fundamentally broken. It's easier to directly bitcast between bridged and native SIL objects. It also produces simpler SIL which can be further optimized
…s immortal
A type (mostly classes) can be attributed with `@_semantics("arc.immortal")`.
ARC operations on values of such types are eliminated.
This is useful for the bridged SIL objects in the swift compiler sources.
This avoids ARC operations on those objects which improves compile time.
eeckstein
force-pushed
the
swift-compile-time
branch
from
2c5f9c7 to
053a38d
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several compile time improvements in the SwiftCompilerSources.
They add up to significant speedups. E.g. I measured a 2x speedup of EscapeUtils (used in alias analysis).
Operand.valuehasRelevantTypein EscapeUtilsFor details see the commit messages