[move-only] Treat mark_must_check assignable_but_not_consumable as ending initialized #64366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t_box (@capture box arg)))) like an inout term user requiring situation. We already did this for the situation without the begin_access. In truth, using the terminator is a bit too wide, but it works for these sorts of arguments that use assignable_but_not_consumable so for expediency (and since we are just walking blocks), I just decided to do something quick. rdar://106208343
…ses similar to inout. I also slightly changed the codegen around where we insert the mark_must_check. Specifically, before we would emit the mark_must_check directly on the ref_element_addr and then insert the access. This had the unfortunate effect that we would hoist any destroy_addr that were actually needed out of the access scope. Rather than do that, I now insert the mark_must_check on the access itself. This results in the destroy_addr being within the scope (like the mark_must_check itself). rdar://105910066
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to do another change to also handle globals.
rdar://106208343
rdar://105910066