Skip to content

[cxx-interop] Do not treat std::pair<UnsafeType, T> as safe #66169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2023
Merged

[cxx-interop] Do not treat std::pair<UnsafeType, T> as safe #66169

merged 1 commit into from
Jun 1, 2023

Conversation

egorzhdan
Copy link
Contributor

rdar://109529750

@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label May 26, 2023
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners May 26, 2023 11:22
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

@egorzhdan
Copy link
Contributor Author

This is required for #65087

@egorzhdan egorzhdan force-pushed the egorzhdan/pair-tuple-unsafe branch from 6081d0e to f277158 Compare June 1, 2023 13:00
@egorzhdan
Copy link
Contributor Author

@swift-ci please smoke test

zoecarver
zoecarver approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@zoecarver zoecarver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you!

@egorzhdan egorzhdan merged commit 630a7fc into main Jun 1, 2023
@egorzhdan egorzhdan deleted the egorzhdan/pair-tuple-unsafe branch June 1, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoecarver zoecarver zoecarver approved these changes

@hyp hyp Awaiting requested review from hyp

Assignees
No one assigned
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egorzhdan @zoecarver