[cxx-interop] compilations that do not enable C++ interoperability sh… #66558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould not be able to import modules that do enable C++ interoperability by default A supplemental hidden frontend option allows advanced users to opt-out of this requirement. Fixes swiftlang#65833 Fixes swiftlang#65832
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ould not be able to import modules that do enable C++ interoperability by default
A supplemental hidden frontend option allows advanced users to opt-out of this requirement.
Fixes #65833
Fixes #65832
When Swift tries to import a module that has C++ interoperability enabled and it imports C++ code, Swift will run into difficult to decipher errors when the compilation doesn't enable interoperability. This change forces Swift to verify that the compilation has C++ interoperability enabled while loading the module, to present a clear error to the user that tells that they need to enabled interop.