[Backtracing][Linux] Fix Ubuntu 20.04-aarch64 CI failures. #66568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These seem to be related to signal handling issues in threads that have been started presumably by the C library or some other library. Primarily this appears to affect Ubuntu 20.04 on aarch64, though I have seen sporadic issues on 18.04 as well. We address the problem by making the thread suspension mechanism more robust in the face of threads with masked signals. rdar://110653167
al45tair
added
🍒 release cherry pick
|
Explanation: The Ubuntu 20.04 aarch64 build fails in the backtracing tests where we perform actual crashes. This appears to be because some system component is injecting an extra thread that has various signals blocked, including the one we're using to suspend threads and capture their thread contexts. |
|
@swift-ci Please test |
|
@swift-ci Please test macOS platform |
mikeash
approved these changes
Jun 13, 2023
nkcsgexi
approved these changes
Jun 13, 2023
tomerd
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These seem to be related to signal handling issues in threads that have been started presumably by the C library or some other library.
Primarily this appears to affect Ubuntu 20.04 on aarch64, though I have seen sporadic issues on 18.04 as well.
We address the problem by making the thread suspension mechanism more robust in the face of threads with masked signals.
rdar://110653167