Improve noncopyable closure diags #66587
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After polishing the diagnostics a bit, I got some of the closure ones wrong:
There are a few problems here:
inout parameter
and instead aclosure capture
.noncopyable '%0' cannot be consumed when captured by a closure
when a non-reconcilable consume happens in a closure. So we should specify "an escaping closure" here.rdar://109908383