Frontend: Deprecate -warn-on-potentially-unavailable-enum-case option #68009
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `-warn-on-potentially-unavailable-enum-case` was introduced, the build system was required to invoke `swift-frontend` at artificially low deployment targets when emitting `.swiftinterface` files for legacy architectures. Because the deployment target was low, some availability diagnostics needed to be de-fanged in order to allow module interface emission to succeed. Today, the build system is able to use the correct deployment target when emitting module interfaces and the `-warn-on-potentially-unavailable-enum-case` is superfluous, so deprecate it. Resolves rdar://114092047
tshortli
requested review from
hborla,
slavapestov,
xedin and
artemcm
as code owners
|
@swift-ci please smoke test |
|
Corresponding driver change (these are not dependent on each other, though): swiftlang/swift-driver#1418 |
artemcm
approved these changes
Aug 18, 2023
beccadax
approved these changes
Aug 18, 2023
tshortli
deleted the
deprecate-warn-on-potentially-unavailable-enum-case
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
-warn-on-potentially-unavailable-enum-casewas introduced, the build system was required to invokeswift-frontendat artificially low deployment targets when emitting.swiftinterfacefiles for legacy architectures. Because the deployment target was low, some availability diagnostics needed to be de-fanged in order to allow module interface emission to succeed. Today, the build system is able to use the correct deployment target when emitting module interfaces and the-warn-on-potentially-unavailable-enum-caseis superfluous, so deprecate it.Resolves rdar://114092047