Skip to content

Revert "Add mandatory SIL pass implementing '@_alwaysEmitConformanceMetadata' protocol attribute" #69689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2023
Merged

Revert "Add mandatory SIL pass implementing '@_alwaysEmitConformanceMetadata' protocol attribute" #69689

merged 1 commit into from
Nov 7, 2023

Conversation

shahmishal
Copy link
Member

Reverts #69609

@shahmishal shahmishal requested a review from artemcm November 7, 2023 06:41
@shahmishal
Copy link
Member Author

@swift-ci smoke test

@shahmishal
Copy link
Member Author

Seeing the test failing on Linux and Windows

Failed Tests (1):
  Swift(linux-aarch64) :: Reflection/preserve_conformance_metadata_attr.swift

Failed Tests (1):
  Swift(windows-x86_64) :: Reflection/preserve_conformance_metadata_attr.swift

@shahmishal shahmishal merged commit cfc46e1 into main Nov 7, 2023
@shahmishal shahmishal deleted the revert-69609-AlwaysEmitConformanceMetadataPreservation branch November 7, 2023 07:16
@shahmishal shahmishal mentioned this pull request Nov 7, 2023
Merged
@artemcm artemcm mentioned this pull request Nov 7, 2023
Merged
@artemcm artemcm mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemcm artemcm Awaiting requested review from artemcm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shahmishal