[stdlib] Fix backwards iteration of word breaking #69728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentyrone
approved these changes
Nov 8, 2023
|
Please clone for 5.10 |
|
@swift-ci please test |
lorentey
approved these changes
Nov 9, 2023
There was a problem hiding this comment.
We really need exhaustive tests for all possible paths through these state machines (grapheme breaking, word breaking), verifying that backwards/forwards iteration and rounding operations are all fully consistent with each other.
We don't even need an oracle for the expected results -- the actual break positions seem less important than that we give consistent results in finite time (preferably proportional to the distance to the break we're returning), on all possible strings of representative code points, up to some small(ish) fixed length.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were accidently hanging when rounding word indices for some concoctions of strings. In particular, where we had a pair of scalars create a constraint for the preceeding pair, but the preceeding extend rules were not taking the constraint into consideration.