ConstantFolding: fix wrong constant folding for float-infinity compares #71610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
stephentyrone
approved these changes
Feb 14, 2024
Only if the other operand of a comparison with Inf is a literal we can be sure that it's not Inf or NaN. Fixes a miscompile rdar://122605966
eeckstein
force-pushed
the
fix-const-folding
branch
from
fad3df3 to
fa85745
Compare
|
@swift-ci test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only if the other operand of an comparison with Inf is a literal we can be sure that it's not Inf or NaN.
Fixes a miscompile
rdar://122605966