Fix hash/isEqual interop conditionals, update tests #71852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
mikeash
approved these changes
Feb 23, 2024
| // Legacy behavior: Equatable in Swift => ObjC hashes with identity | ||
| TestSwiftObjectNSObjectDefaultHashValue(e) | ||
| let msg = "Obj-C `-hash` ... type `SwiftObjectNSObject.\(type(of: e))` ... Equatable but not Hashable\n" | ||
| fputs(msg, stderr) |
There was a problem hiding this comment.
Alas, no. Maybe I should comment it a bit more, though.
There's some FileCheck stuff here to verify that the runtime is really emitting some warning logs for some of these cases. So when we don't take those new paths, we have to emit a fake log message to make FileCheck happy. Maybe there's a better way to do this....
There was a problem hiding this comment.
Oh, I see, I didn't realize FileCheck was involved in this one. Makes sense. I think the alternative would be to use --check-prefix to check for different things in different contexts, but that probably wouldn't be an improvement here.
|
@swift-ci Please test |
1 similar comment
|
@swift-ci Please test |
Github PR swiftlang#71620 mixed up one of the bincompat conditionals. It also had some errors in the tests for ObjC interop. For now, this leaves the legacy behavior in place for all Apple platforms.
tbkka
force-pushed
the
tbkka-rdar123422591
branch
from
737c95a to
2be0f04
Compare
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github PR #71620 mixed up one of the bincompat conditionals. It also had some errors in the tests for ObjC interop.
For now, this leaves the legacy behavior in place for all Apple platforms.
Resolves rdar://123422591