Skip to content

[6.0] build-script: add flag to pass arguments to dsymutil #72554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

edymtt
Copy link
Contributor

@edymtt edymtt commented Mar 25, 2024

Explanation: add flag to pass arguments to dsymutil when extracting symbols for Darwin platforms
Radar: rdar://125092216
Scope: build logic that extract symbols in builds for Darwin platforms
Risk: low

  • adding a flag is a well understood activity
  • this affected logic is opt in and used by a limited subset of the presets running in CI (namely, jobs generating the macOS toolchain)

Testing: added tests to the Python and BuildSystem suites to ensure the flag is passed appropriately
Reviewed By: Mishal Shah on #72486

This is currently needed to disable DWARF verification in
some Apple internal configurations.

Addresses rdar://125092216

(cherry picked from commit efdd495)
@edymtt edymtt requested a review from shahmishal March 25, 2024 14:38
@edymtt edymtt requested a review from a team as a code owner March 25, 2024 14:38
@edymtt
Copy link
Contributor Author

edymtt commented Mar 25, 2024

@swift-ci please test

@edymtt
Copy link
Contributor Author

edymtt commented Mar 25, 2024

@swift-ci please test WebAssembly

@edymtt
Copy link
Contributor Author

edymtt commented Mar 25, 2024

@swift-ci please build toolchain

@shahmishal shahmishal merged commit ce9feb5 into swiftlang:release/6.0 Mar 27, 2024
@edymtt edymtt deleted the edymtt/add-flag-to-pass-arguments-to-dsymutil-6.0 branch March 27, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants